multipath: tweak logging style
authorBenjamin Marzinski <bmarzins@redhat.com>
Wed, 10 Oct 2018 18:01:08 +0000 (13:01 -0500)
committerChristophe Varoqui <christophe.varoqui@opensvc.com>
Fri, 12 Oct 2018 07:37:33 +0000 (09:37 +0200)
When multipathd commands are run, errors should be printed to stderr,
instead of syslog. Also, when the multipath is run and calls
device-mapper, device-mapper should log to stderr instead of stdout,
just like multipath does now.

Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
libmultipath/devmapper.c
multipathd/main.c

index 8136d15..0433b49 100644 (file)
@@ -80,11 +80,11 @@ dm_write_log (int level, const char *file, int line, const char *f, ...)
                        strftime(buff, sizeof(buff), "%b %d %H:%M:%S", tb);
                        buff[sizeof(buff)-1] = '\0';
 
-                       fprintf(stdout, "%s | ", buff);
+                       fprintf(stderr, "%s | ", buff);
                }
-               fprintf(stdout, "libdevmapper: %s(%i): ", file, line);
-               vfprintf(stdout, f, ap);
-               fprintf(stdout, "\n");
+               fprintf(stderr, "libdevmapper: %s(%i): ", file, line);
+               vfprintf(stderr, f, ap);
+               fprintf(stderr, "\n");
        } else {
                condlog(level, "libdevmapper: %s(%i): ", file, line);
                log_safe(level + 3, f, ap);
index af33239..5f0193b 100644 (file)
@@ -2984,6 +2984,7 @@ main (int argc, char *argv[])
                        logsink = -1;
                        break;
                case 'k':
+                       logsink = 0;
                        conf = load_config(DEFAULT_CONFIGFILE);
                        if (!conf)
                                exit(1);
@@ -3013,6 +3014,7 @@ main (int argc, char *argv[])
                char * s = cmd;
                char * c = s;
 
+               logsink = 0;
                conf = load_config(DEFAULT_CONFIGFILE);
                if (!conf)
                        exit(1);