multipathd: set DAEMON_CONFIGURE from uxlsnr thread
authorMartin Wilck <mwilck@suse.com>
Fri, 2 Nov 2018 12:24:00 +0000 (13:24 +0100)
committerChristophe Varoqui <christophe.varoqui@opensvc.com>
Wed, 14 Nov 2018 07:22:27 +0000 (08:22 +0100)
Commit ee01e841 had the intention to make multipathd quit if
the client socket couldn't be set up, because the unix socket
listener is vital for signal handling in multipathd.
But during startup, this condition might be lost if the main
thread doesn't wait for the unix listener to initialize.

Fixes: ee01e841 "multipathd: handle errors in uxlsnr as fatal"

Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
multipathd/main.c

index a91a14c..9052b56 100644 (file)
@@ -207,9 +207,8 @@ static void config_cleanup(void *arg)
        pthread_mutex_unlock(&config_lock);
 }
 
-void post_config_state(enum daemon_status state)
+static void __post_config_state(enum daemon_status state)
 {
-       pthread_mutex_lock(&config_lock);
        if (state != running_state) {
                enum daemon_status old_state = running_state;
 
@@ -219,7 +218,14 @@ void post_config_state(enum daemon_status state)
                do_sd_notify(old_state);
 #endif
        }
-       pthread_mutex_unlock(&config_lock);
+}
+
+void post_config_state(enum daemon_status state)
+{
+       pthread_mutex_lock(&config_lock);
+       pthread_cleanup_push(config_cleanup, NULL);
+       __post_config_state(state);
+       pthread_cleanup_pop(1);
 }
 
 int set_config_state(enum daemon_status state)
@@ -1515,6 +1521,10 @@ uxlsnrloop (void * ap)
                exit_daemon();
                goto out_sock;
        }
+
+       /* Tell main thread that thread has started */
+       post_config_state(DAEMON_CONFIGURE);
+
        set_handler_callback(LIST+PATHS, cli_list_paths);
        set_handler_callback(LIST+PATHS+FMT, cli_list_paths_fmt);
        set_handler_callback(LIST+PATHS+RAW+FMT, cli_list_paths_raw);
@@ -2734,11 +2744,26 @@ child (void * param)
         */
        conf = NULL;
 
-       /*
-        * Signal start of configuration
-        */
-       post_config_state(DAEMON_CONFIGURE);
+       pthread_cleanup_push(config_cleanup, NULL);
+       pthread_mutex_lock(&config_lock);
 
+       __post_config_state(DAEMON_IDLE);
+       rc = pthread_create(&uxlsnr_thr, &misc_attr, uxlsnrloop, vecs);
+       if (!rc) {
+               /* Wait for uxlsnr startup */
+               while (running_state == DAEMON_IDLE)
+                       pthread_cond_wait(&config_cond, &config_lock);
+       }
+       pthread_cleanup_pop(1);
+
+       if (rc) {
+               condlog(0, "failed to create cli listener: %d", rc);
+               goto failed;
+       }
+       else if (running_state != DAEMON_CONFIGURE) {
+               condlog(0, "cli listener failed to start");
+               goto failed;
+       }
 
        if (poll_dmevents) {
                if (init_dmevent_waiter(vecs)) {
@@ -2761,10 +2786,6 @@ child (void * param)
                goto failed;
        }
        pthread_attr_destroy(&uevent_attr);
-       if ((rc = pthread_create(&uxlsnr_thr, &misc_attr, uxlsnrloop, vecs))) {
-               condlog(0, "failed to create cli listener: %d", rc);
-               goto failed;
-       }
 
        /*
         * start threads